cljsjs / packages

DEPRECATED: Javascript libraries packaged up with Google Closure externs
http://cljsjs.github.io
786 stars 816 forks source link

Add react-component/tooltip #771

Open RyanBertrand opened 7 years ago

RyanBertrand commented 7 years ago

I am struggling a bit with how we include something like this that does not include flat .js and .min.js file(s). Would be great to see and learn how to integrate this.

https://github.com/react-component/tooltip

Thanks!

kommen commented 7 years ago

@RyanBertrand I ran into the same issue when packaging Slate and ended up using https://unpkg.com/. See https://github.com/cljsjs/packages/blob/f62ea137dae2c79fa9dd0e9198d40a895761d2f6/slate/build.boot#L21

RyanBertrand commented 7 years ago

@kommen thanks - that is very cool! It looks like react-component/tooltip doesn't build a standalone js and min file like Slate does in the /dist directory.

https://unpkg.com/rc-tooltip@3.4.2/

I think this solution works for a few other libs I am looking into using. Thanks for your help!

RyanBertrand commented 7 years ago

It looks like rc-slider made it work. Running webpack to spit out a standalone .js and .min.js file.

rc-slider is from the same author as rc-tooltip.

https://github.com/cljsjs/packages/tree/master/rc-slider