search

clkao / docker-postgres-plv8

Docker image postgres with plv8
https://registry.hub.docker.com/u/clkao/postgres-plv8/
MIT License
45 stars 38 forks source link

Fix PLV8_VERSION build directory suffix #23

Closed ruimarinho closed 7 years ago

clkao commented 7 years ago

This is for turning v2.0.0 to 2.0.0?

ruimarinho commented 7 years ago

This only fixes the cd /tmp/build/plv8-v2.0.0 when it should have been cd /tmp/build/plv8-2.0.0 when building. If you enable Travis we can get the build status tested instead of having a failure on Docker Cloud.

clkao commented 7 years ago

ok travis enabled.

ruimarinho commented 7 years ago

Awesome, thank you. Watching the master build.

clkao commented 7 years ago

Since the 1.5 and 2.0 builds require building v8 from source, it might worth considering creating v8 images and use travis to build with volume-mount, and then push to docker hub from travis' after_success rather than relying on docker hub/cloud's build infrastructure.

ruimarinho commented 7 years ago

That sounds like a good idea, even though I don't expect many releases from PLV8.