New release to support 9.4.

[GoogleCodeExporter]

Hi,

I would like to update the Debian plv8 package to support PostgreSQL 9.4. 
Please release a new version that includes the 9.4 fixes.

Thanks,
Christoph

Original issue reported on code.google.com by christophberg.myon@googlemail.com on 6 Jul 2014 at 2:29

[GoogleCodeExporter]

There seems to be 2 areas that need adjustment:

1) throw() declaration in functions, e.g.

c++ -Wall -O2  -I. -I./ -I/usr/local/include/postgresql/server 
-I/usr/local/include/postgresql/internal -I/usr/local/inc
lude/libxml2 -I/usr/include -I/usr/local/include -I/usr/local/include -fPIC -c 
-o plv8.o plv8.cc
plv8.cc:50:7: error: exception specification in declaration does not match 
previous declaration
Datum   plv8_call_handler(PG_FUNCTION_ARGS) throw();
        ^
plv8.cc:43:21: note: previous declaration is here
PG_FUNCTION_INFO_V1(plv8_call_handler);
                    ^
/usr/local/include/postgresql/server/fmgr.h:350:7: note: expanded from macro 
'PG_FUNCTION_INFO_V1'
Datum funcname(PG_FUNCTION_ARGS); \
      ^

2) parseTypeString now takes 4 args

/usr/bin/c++ -Wall -O2  -I. -I./ -I/usr/local/include/postgresql/server 
-I/usr/local/include/postgresql/internal -I/usr/
local/include/libxml2 -I/usr/include -I/usr/local/include -I/usr/local/include 
-fPIC -c -o plv8_func.o plv8_func.cc
plv8_func.cc:502:3: error: no matching function for call to 'parseTypeString'
                parseTypeString(typestr, &types[i], &typemod);
                ^~~~~~~~~~~~~~~
/usr/local/include/postgresql/server/parser/parse_type.h:50:13: note: candidate 
function not viable: requires 4
      arguments, but 3 were provided
extern void parseTypeString(const char *str, Oid *typeid_p, int32 *typmod_p, 
bool missing_ok);
            ^
===

Also, it would be great if the Makefile contained

# set your custom C++ compler
CUSTOM_CC = c++

by default (not g++). It will work in more environment without fiddling (e.g. 
on FreeBSD 10 where clang is the default compiler).

Original comment by tobias.o...@gmail.com on 3 Oct 2014 at 5:43

[GoogleCodeExporter]

It looks like all the work has been done, but I'm not sure what needs to be 
done to make a new release. Just change the release versions in the Makefile 
and META.json file, then tag it?

Original comment by and...@dunslane.net on 28 Jan 2015 at 10:16

[GoogleCodeExporter]

Original comment by AMDuns...@gmail.com on 28 Jan 2015 at 10:20

• Changed state: Accepted

[GoogleCodeExporter]

Yes, as far as it builds and regression passes with latest 9.4, we can just 
make change to Changes file and tag it.  Refer 
7b2bb6dc3dfe7645f9fe5b2ca0e631472b13645c and 
e4400c1fbbed6e5baf163b7367ff503b3a87abfd for 1.4 release.  You can also package 
it using package.sh and upload it to pgxn (Andrew, you should have access)

Original comment by umi.tan...@gmail.com on 2 Feb 2015 at 7:50

[GoogleCodeExporter]

Release 1.4.3 is on pgxn

Original comment by AMDuns...@gmail.com on 5 Feb 2015 at 4:37

• Changed state: Done