clkao / plv8js-migrated

Automatically exported from code.google.com/p/plv8js
Other
0 stars 0 forks source link

Can't compile branch v1.4 under PostgreSQL 9.3 #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. I am compiling with mingw-w64 chain
2. Did a git clone -b r1.4 https://code.google.com/p/plv8js/ plv8js
3. Compiled as usual except pointing at my 9.3 development instance which I 
have compiled several other extensions for.

What is the expected output? 
I did the same with 9.4 and 9.4 was fine -- it should compile and make install 
check and all that stuff should work

What do you see instead?
rm -f plv8_config.h plv8.control plv8--1.4.2.sql plcoffee.control 
plcoffee--1.4.2.sql  plls.control plls--1.4.2.sql coffee-script.cc livescript.cc
rm -f plv8.dll   libplv8.a libplv8dll.def libplv8.pc
rm -f plv8.o plv8_type.o plv8_func.o plv8_param.o coffee-script.o livescript.o
rm -rf results/ regression.diffs regression.out tmp_check/ log/
sed -e 's/^#undef PLV8_VERSION/#define PLV8_VERSION "1.4.2"/' plv8_config.h.in 
> plv8_config.h
g++ -Wall -O2  -I. -I. 
-Ic:/MING64~1/projects/POSTGR~1/rel/PG9~1.3W6/include/server 
-Ic:/MING64~1/projects/POSTGR~1/rel/PG9~1.3W6/include/internal -I/proje
OSTGR~1/rel/PG9~1.3W6/include/server/port/win32 -fPIC -c -o plv8.o plv8.cc
plv8.cc:1:0: warning: -fPIC ignored for target (all code is position 
independent) [enabled by default]
 /*-------------------------------------------------------------------------
 ^
plv8.cc: In function 'Datum common_pl_call_validator(FunctionCallInfo, 
Dialect)':
plv8.cc:699:66: error: 'CheckFunctionValidatorAccess' was not declared in this 
scope
  if (!CheckFunctionValidatorAccess(fcinfo->flinfo->fn_oid, fn_oid))
                                                                  ^
Makefile:68: recipe for target `plv8.o' failed
make: *** [plv8.o] Error 1

I also tried 1.4.2 tagged zip version and had the same problem. I then jumped 
to 1.4.0 tagged and that one worked fine

What version of the product are you using? On what operating system?

!.4.2, 1.4 git branch on mingw-w64 (windows 7 64-bit)

Please provide any additional information below.

Original issue reported on code.google.com by l...@pcorp.us on 30 Dec 2014 at 12:25

GoogleCodeExporter commented 9 years ago
I think this might have been a false alarm.  Please close out.
I realized after I checked that my PostgreSQL 9.3 was version 9.3.0.
So I recompiled with PostgreSQL 9.3.5 source and then install worked fine.

So don't know if it was 9.3.0 at fault or I some how got a mix of newer headers 
polluting my 9.3. Anyway seems to be a non-issue now.

Original comment by l...@pcorp.us on 30 Dec 2014 at 7:37

GoogleCodeExporter commented 9 years ago

Original comment by chiali...@gmail.com on 4 Jan 2015 at 8:21