search

clkao / plv8js-migrated

Automatically exported from code.google.com/p/plv8js
Other
0 stars 0 forks source link

V8_SRCDIR option disappeared #46

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 

It looks like the V8_SRCDIR option disappeared in 
90190dc310d1c460dfb510c9e30925cc7575d836. I was using that :)

Original issue reported on code.google.com by t.ark...@gmail.com on 20 Dec 2012 at 5:40

GoogleCodeExporter commented 9 years ago 
And here's a patch that brings it back.

Original comment by t.ark...@gmail.com on 20 Dec 2012 at 7:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Scratch... V8_SRCDIR was merely an experiment that didn't seem to work well.  
If you say you put libv8.so in your V8_OUTDIR, how do you load that library in 
your server?  If the server can load it, you should have LD_LIBRARY_PATH set or 
something, so should plv8 find it.  The problem I've seen in my development 
was, it sometimes confuses the build system and you pick one version of header 
file and the server will load another version of library.

Original comment by umi.tan...@gmail.com on 21 Dec 2012 at 8:53

GoogleCodeExporter commented 9 years ago 
Applied to the master.  It might make sense to have such options as you claim.  
Thanks for the patch!

Original comment by umi.tan...@gmail.com on 20 Feb 2013 at 8:15