don't use mutable module global for config.

Quite a few of "my" clld apps with lexical data use Parameter for cross-linguistic word meanings and Value for the forms. The idea here is that the simplest data model for linguistic data - triples of language, feature and Value- can also be applied to lexical data like Wordlist.

But I agree, as soon as the forms become objects of study (rather than just the language), units and unitparameters make more sense.

I'd still vote for the simple case being the default.

Florian Matter @.***> schrieb am Di., 1. Nov. 2022, 02:05:

@.**** commented on this pull request.

In src/clld_markdown_plugin/init.py https://github.com/clld/clld-markdown-plugin/pull/4#discussion_r1009988566 :

"ParameterTable": UnitParameter,

"sources.bib": Source,

"Source": Source, -} -model_map = {} -function_map = {}

+def settings(custom: typing.Optional[dict] = None) -> dict:

def full_spec(spec):

return spec if isinstance(spec, dict) else {

'route': spec.name.split('.')[-1].lower() if spec else '', 'model': spec}

res = {

'model_map': {

"LanguageTable": full_spec(common.Language),

"ParameterTable": full_spec(common.Parameter),

My reasoning here was based on the assumption that if a CLLD app was to use this plugin, it would be much more likely that the author(s) would want to refer in their markdown content to meanings of forms (which I understand unitparameters to be), rather than typological parameters (which I understand parameters to be).

— Reply to this email directly, view it on GitHub https://github.com/clld/clld-markdown-plugin/pull/4#discussion_r1009988566, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUOKHASXGHSEPDN25UYKDWGBUGFANCNFSM6AAAAAARSE5BNY . You are receiving this because you authored the thread.Message ID: @.***>

clld / clld-markdown-plugin

don't use mutable module global for config. #4

@.**** commented on this pull request.