search

clld / clld

A web framework to display Cross Linguistic Linked Data.
http://clld.org
Other
54 stars 24 forks source link

removed download button of the table's toolbar #244 #245

Closed Bibiko closed 2 years ago

Bibiko commented 2 years ago

renamed class DownloadWidget into BaseToolbarWidget

codecov[bot] commented 2 years ago

Codecov Report

Merging #245 (4192080) into master (5730967) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          117       117           
  Lines         5263      5282   +19     
=========================================
+ Hits          5263      5282   +19
Impacted Files Coverage Δ
src/clld/web/util/downloadwidget.py 100.00% <ø> (ø)
src/clld/web/datatables/base.py 100.00% <100.00%> (ø)
tests/test_web_datatables_base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5730967...4192080. Read the comment docs.

xrotwang commented 2 years ago

So, the databale's Toolbar shouldn't inherit from DownloadWidget anymore, I think.