search

clld / glottolog3

glottolog2 re-implemented as CLLD app
MIT License
108 stars 25 forks source link

Number of languages listed on "About languoids" omits isolates #114

Closed xrotwang closed 5 years ago

xrotwang commented 5 years ago

The number of languages (total and L1) listed on "About languoids" is too low, because the isolates are omitted. This is presumably due to joining on family_pk (which is NULL for isolates) in order to compute counts for the "special" families.

xrotwang commented 5 years ago

@d97hah just noticed this somewhat embarrassing bug.

d97hah commented 5 years ago

That listing has had worse bugs before ;-)

Pada tanggal Sel, 18 Jun 2019 pukul 16.25 Robert Forkel < notifications@github.com> menulis:

@d97hah https://github.com/d97hah just noticed this somewhat embarrassing bug.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/clld/glottolog3/issues/114?email_source=notifications&email_token=AA2QHSEM67D2FVTD3A5WNE3P3DV6BA5CNFSM4HZAUF7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6ZU4Q#issuecomment-503159410, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2QHSGYQTLR3I3TVAVPXWDP3DV6BANCNFSM4HZAUF7A .

HedvigS commented 5 years ago

(That's one of the reasons I've added a separate Family_ID column in my sheet with more things separated out, I had isolates being omitted a few times in my R code before I realised it was because their Family_IDs were null :) .)