clld / phoible

PHOIBLE Online
http://phoible.org
Apache License 2.0
42 stars 13 forks source link

Odd parsing of links in detail_html.mako #26

Closed SimonGreenhill closed 3 years ago

SimonGreenhill commented 3 years ago

There is some odd misparsing of the detail template below -- note the extra "}" after Moran et al. 2012} and Cysouw et al. 2012}:

For a detailed description of PHOIBLE, see Moran 2012. For examples of some of the research we are doing with PHOIBLE, see: Moran et al. 2012}, Cysouw et al. 2012}, McCloy et al. 2013 and Moran & Blasi, Cross-linguistic comparison of complexity measures in phonological systems, forthcoming. 

Seems to be coming from this template, but I can't see where the extra "}"'s are coming from?

https://github.com/clld/phoible/blob/9539cacc5d50343cc03a9e2788c1b60956275db5/phoible/templates/dataset/detail_html.mako#L36

<p>For a detailed description of PHOIBLE, see
    ${h.link(request, sources['Moran2012a'])}.
    For examples of some of the research we are doing with PHOIBLE, see:

    ${h.link(request, sources['Moran_etal2012'])},
    ${h.link(request, sources['Cysouw_etal2012'])},
    ${h.link(request, sources['mccloy_etal2013'])}
    and Moran &amp; Blasi, Cross-linguistic comparison of complexity measures in phonological systems, forthcoming.
</p>
SimonGreenhill commented 3 years ago

Ah, just spotted that this was addressed in #24.