search

cllns / material_design_lite-rails

:large_blue_circle: Material Design Lite, for Rails
MIT License
127 stars 12 forks source link

Issues with heroku? #6

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hey!

Has anyone tried deploying to heroku?

Its not working for me for some reason.

URL: https://staging.counterstrike.io/ Screenshot: http://i.imgur.com/6rtvaSw.png What it looks like in development (what its supposed to look like): http://i.imgur.com/aCHRvKY.png

Thanks.

cllns commented 9 years ago

Ooh, thanks so much for reporting this. I haven't had the chance to deploy this anywhere, so it's super valuable.

I'll try it out now and keep you updated.

ghost commented 9 years ago

Awesome, thanks.

cllns commented 9 years ago

Just deployed a site here, with a header that uses CSS and JS (click the hamburger or search bar): http://test-mdl.herokuapp.com/ and it seems to work fine. When I click a link, the JS stop working, but no errors are triggered. I think that might be an effect of turbolinks :sweat_smile:

Rails 4.2.0 And Ruby 2.0 (on heroku) / Ruby 2.2 (on dev)

Are you using the rails_12factor gem? I know that does stuff with assets.

ghost commented 9 years ago

It didnt work with rails12factor so i added it and it still doesnt work.

Can you push it to github so I can compare it with my site?

On Wed, Jul 8, 2015 at 4:18 PM sean collins notifications@github.com wrote:

Just deployed a site here, with a header that uses CSS and JS (click the hamburger or search bar): http://test-mdl.herokuapp.com/ and it seems to work fine. When I click a link, the JS stop working, but no errors are triggered. I think that might be an effect of turbolinks [image: :sweat_smile:]

Rails 4.2.0 And Ruby 2.0 (on heroku) / Ruby 2.2 (on dev)

Are you using the rails_12factor https://github.com/heroku/rails_12factor gem? I know that does stuff with assets.

— Reply to this email directly or view it on GitHub https://github.com/cllns/material_design_lite-rails/issues/6#issuecomment-119756934 .

cllns commented 9 years ago

Here you go! https://github.com/cllns/test-mdl

ghost commented 9 years ago

Thats really weird. here are my application files: https://gist.github.com/nahtnam/1b5cdc96f7c2dd8d2e05

Do you see anything weird?

cllns commented 9 years ago

Yours looks like a JS error to me. There's no errors in the console, but the styles (fonts, footer color) seems OK.

Try commenting out Ember and see if that works. Also maybe try moving the order of the JS files?

I don't think it matters, but I prefer the Sass import syntax to the CSS manifest file syntax. Even more than that, I think you should pick a single one and stick to it.

ghost commented 9 years ago

What do you mean? I am using the Sass import syntax right?

Everything is working fine in development, but not in production. It probably does have something to do with javascript. Ill try messing around with the order and stuff. Let me know if you come up with a better idea though.

ghost commented 9 years ago

Fixed.

It had to do with the css caching of cloudflare.