clober-dex / coupon-finance

Coupon Finance Solidity Contracts

Other

1 stars 0 forks source link

Closed detectivekim closed 11 months ago

detectivekim commented 11 months ago

Description

Several issues for #145

remainingDebt < minDebtCheck will be true even if remainingDebt=0, must check for that.
there is edge case when couponsToBurn is not zero. Consider minDebtAmount always fluctuates due to price changes. Then remainingDebt = minDebtAmount can set new debt to be higher than before!
check of remainingDebt < minDebtAmount must be repeated at the end because we further reduce debt in line 88.

detectivekim commented 11 months ago

@trust1995 Fixed.

trust1995 commented 11 months ago

Advise to add a test for edge case (2). Other than that, seems good.