clockbyte / admobadapter

It wraps your Adapter to display Admob native ads and banners in a ListView/RecyclerView data set. It based on the Yahoo fetchr project https://github.com/yahoo/fetchr
Apache License 2.0
237 stars 75 forks source link

banners not showing #114

Closed jenniestrongbow closed 6 years ago

jenniestrongbow commented 6 years ago

Hello, our AdmobBannerAdapterWrapper simply never displays ads. It only displays a blank space. And the ads have enough space.

We're using version 1.4.6.

adapterWrapper = AdmobBannerAdapterWrapper.builder(activity) .setLimitOfAds(10) .setFirstAdIndex(2) .setNoOfDataBetweenAds(10) .setAdapter(adapter) .setAdViewWrappingStrategy(new BannerAdViewWrappingStrategy()) .build(); listview.setAdapter(adapterWrapper);

Please help.

Thanks

kot331107 commented 6 years ago

Hi @jenniestrongbow , how long time ago have you created a new banner in your Admob console?

jenniestrongbow commented 6 years ago

I tried with two AdMob banners. One I created months ago. And one I created a couple of days earlier. Thanks

kot331107 commented 6 years ago

@jenniestrongbow could you please share some test project to reproduce it? Could you reproduce it with our sampleapp project?

jenniestrongbow commented 6 years ago

Hello, I will try your sampleapp project and get back to you. Thanks!!!

jenniestrongbow commented 6 years ago

I am sorry I wasted your time. It is working fine. I was just not giving my ads enough space for them to show. Thanks for your time.

kot331107 commented 6 years ago

@jenniestrongbow welcome! actually I have wasted no time at all, you solved the issue yourself :)

Mayur-007 commented 6 years ago

@jenniestrongbow How you solved it? facing the same issue.

Mayur-007 commented 6 years ago

Super Upset by your library. Wasted almost 5 hours and found the problem that I had given padding in RecyclerView. Please write this thing on the home page of the library in big font. "Do not set padding or margin to List", so other people can be saved.

kot331107 commented 6 years ago

@Mayur-007 Please go to RTFM and see https://github.com/clockbyte/admobadapter/wiki/Cookbook#howto-handle-the-error-wads-not-enough-space-to-show-ad-wants-320-100-has-300-100 :) 5 hours is quite long for this issue so I guess you spent it looking for porn ;)

Mayur-007 commented 6 years ago

I've read manual https://github.com/clockbyte/admobadapter/wiki/Cookbook#the-recipe-3-for-a-recyclerview-scrolling-with-banners I wasn't getting any error (Technically), so did not see any logs and couldn't realize, it was just blank space. The least you can do is prevent it. Rather than making people find an error and then providing a solution, you can do something that they don't find the error in the first place; like making a note as in requirements and write this thing in it.

I wasn't looking porn but It would have been better Idea than to solve a stupid bug. I appreciate the effort you made by building this library and it is great but this seems stupid thing. It's not a feature my friend, it's a bug.

kot331107 commented 6 years ago

@Mayur-007 So see friend, have you tried to look into the LogCat with error level = DEBUG and a filter like "ads"? It should warn you about the ad's size.

Mayur-007 commented 6 years ago

I got it resolved, but now I'm facing the wrong position in RecyclerView. I looked at this but I don't think RecyclerView has a setOnItemClickListener method. & I want the correct index inside Adapter rather than in Activity. I tried with setAdapterCalculator but don't know how to make it work.