search

clockbyte / admobadapter

It wraps your Adapter to display Admob native ads and banners in a ListView/RecyclerView data set. It based on the Yahoo fetchr project https://github.com/yahoo/fetchr
Apache License 2.0
237 stars 75 forks source link

show loading icon or view while loading the Ad #115

Closed ahmedgalal closed 6 years ago

ahmedgalal commented 6 years ago

As per google guidelines, you must show an empty space before the Ad shows to avoid unintentional clicks, so i suggest adding a loading view while loading the Ad, it would make the list looks good without breaking google guidelines.

showing only white space kinda breaks the design.

kot331107 commented 6 years ago

@ahmedgalal Plz check the sampleapp demo application for instance. We definitely show there a "loading" view while banners are preparing to display. Also see https://github.com/clockbyte/admobadapter/wiki/Cookbook#in-case-you-want-to-wrap-your-ad-blocks-into-a-viewgroup-cardview-framelayout-etc to see how to replace white space with your customized "loading view". I would start investigation from the sampleapp.