clockbyte / admobadapter

It wraps your Adapter to display Admob native ads and banners in a ListView/RecyclerView data set. It based on the Yahoo fetchr project https://github.com/yahoo/fetchr
Apache License 2.0
237 stars 75 forks source link

Ignoring app ID and defaulting to UNIT_ID_DEFAULT_BANNER test ads #117

Closed HaydenCampbell closed 6 years ago

HaydenCampbell commented 6 years ago

Admobadapter version or commit: v1.4.6

Android compileSdkVersion: 27

Issue description briefly: I can't get the app to display real ads, it seems to be ignoring my app ID in the strings resource and defaulting to String UNIT_ID_DEFAULT_BANNER = "ca-app-pub-7246006002889486/6993938523"; // Google's Test unit ID from the BannerAdPreset class.

Steps to reproduce: You can build the sample app MainActivity_ListView_Banner with your own app ID in the strings resource and it will ignore it and default to Google's Test unit ID.

kot331107 commented 6 years ago

@HaydenCampbell will check!

Update: try to pass your admob ID to the method AdmobBannerAdapterWrapper.Builder.setSingleAdUnitId(<your admob Id>)

instead of changing it in resources

HaydenCampbell commented 6 years ago

Thanks, that works!