search

clockbyte / admobadapter

It wraps your Adapter to display Admob native ads and banners in a ListView/RecyclerView data set. It based on the Yahoo fetchr project https://github.com/yahoo/fetchr
Apache License 2.0
237 stars 75 forks source link

How to add multiple ad unit IDs in AdmobExpressRecyclerAdapterWrapper #91

Closed Shajeel-Afzal closed 7 years ago

Shajeel-Afzal commented 7 years ago

I am using 1.3.1 version of the library and I want to add multiple ad units IDs in AdmobExpressRecyclerAdapterWrapper so that a different ad is loaded each time in the list. Is it possible? I don't want to update the library to 1.4.5 for now because I am facing issues with 26.0.1 support library.

kot331107 commented 7 years ago

@Shajeel-Afzal You could try to update to 1.4.1, it uses the 25.3.1 support lib. However, yes, it supports multiple ad ids since 1.3.1, kindly check here

Shajeel-Afzal commented 7 years ago

Thank you so much for the quick update.

kot331107 commented 7 years ago

@Shajeel-Afzal you welcome! please also check releases info. There were much changes and major/minor fixes since 1.3.1 so I would strongly advice you to go for 1.4.1

Shajeel-Afzal commented 7 years ago

One quick question @kot331107, the ad container should be removed/hidden if ad fails to load for some reason. Are you going to add support for that or is the library handles that?

kot331107 commented 7 years ago

@Shajeel-Afzal Yeah it handles. But there was a fix in 1.4.5 concerning this feature in the Express Recycler Wrapper. So maybe it is the best option for you to clone the latest code from the master branch locally and then change all 26 to 25 versions in build.gradle (build tools, compile, target and all libs).

Shajeel-Afzal commented 7 years ago

Super Awesome.