While working on the new C# codegen, I accidentally noticed that those tests were passing even when they clearly should've been failing due to changed output.
After running with --nocapture, I found out it's because the tests are silently skipped and reported as successful when rust_wasm_test.wasm isn't built.
This further led to finding that rust_wasm_test.wasm is never built - the relevant module results in rust_wasm_test_module.wasm instead - so these tests have been incorrectly passing for ages.
This PR changes them to actually build the module as part of testing and updates the snapshots to latest master.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the
corresponding GitHub label.
Expected complexity level and risk
1
How complicated do you think these changes are? Grade on a scale from 1 to 5,
where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff,
but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR,
and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!
[x] Write a test you've completed here.
[ ] Write a test you want a reviewer to do here, so they can check it off when they're satisfied.
Description of Changes
While working on the new C# codegen, I accidentally noticed that those tests were passing even when they clearly should've been failing due to changed output.
After running with
--nocapture, I found out it's because the tests are silently skipped and reported as successful whenrust_wasm_test.wasmisn't built.This further led to finding that
rust_wasm_test.wasmis never built - the relevant module results inrust_wasm_test_module.wasminstead - so these tests have been incorrectly passing for ages.This PR changes them to actually build the module as part of testing and updates the snapshots to latest master.
API and ABI breaking changes
If this is an API or ABI breaking change, please apply the corresponding GitHub label.
Expected complexity level and risk
1
How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change.
This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code.
If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways.
Testing
Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!