search

clockworklabs / SpacetimeDB

Multiplayer at the speed of light
https://spacetimedb.com
Other
4.41k stars 110 forks source link

The banishment of Address #1880

Closed cloutiertyler closed 1 month ago

cloutiertyler commented 1 month ago

Description of Changes

Jeff and I worked on Friday to remove all uses of Address as an identifier for a database. Address is still used for what will eventually become ConnectionId.

There is a corresponding private PR.

API and ABI breaking changes

This breaks the CLI API as well as the HTTP and WebSocket APIs. It also edits the system tables.

Expected complexity level and risk

4

This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code.

This impacts many APIs as mentioned above. The change is mostly mechanical, but not entirely.

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!

mamcx commented 1 month ago

lFYI this could conflict and/or get good help from https://github.com/clockworklabs/SpacetimeDB/pull/1876, in special everywhere we pass Address and/or ExecutionContext it will removed it in #1876, ie I several of the same lines doing that refactor.

cloutiertyler commented 1 month ago

Although I am a partial author of this, I just want to so that this one looks good to me.