search

clockworklabs / SpacetimeDB

Multiplayer at the speed of light
https://spacetimedb.com
Other
4.41k stars 110 forks source link

C# endianness fixes #1964

Closed kazimuth closed 1 day ago

kazimuth commented 1 week ago

Description of Changes

Similar fixes to the previous endianness fixes (https://github.com/clockworklabs/SpacetimeDB/pull/1926) for C#.

API and ABI breaking changes

Reverts a previous API break which (I believe) printed Identities and Addresses backwards in C#. Otherwise, only documents existing behavior & adds methods.

Expected complexity level and risk

1

Testing

I am not sure how to add unit tests to the C# bindings, @RReverser please advise. E: NVM, figured it out.

kazimuth commented 1 week ago

Okay this should be ready for merge

kazimuth commented 1 week ago

I'm nervous about these internal test failures, I don't know what's causing them.

gefjon commented 1 week ago

I'm nervous about these internal test failures, I don't know what's causing them.

These are a known issue that should hopefully be fixed by tomorrow.