mamcx commented 1 week ago

Description of Changes

When trying to infer the type for UNION like queries we get:

 Unexpected type: (expected) (u32: U32f32: F32str: String) != (u32: U32f32: F32str: String) (inferred)

Because the check is only 'nominal' (aka: test both table_id are the same), this patch also makes a structural check.

Expected complexity level and risk

1

Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!

[x] Write a test you've completed here.
[ ] Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

cloutiertyler commented 6 days ago

bots please

(doing this for unrelated reasons to this PR)

github-actions[bot] commented 6 days ago

Bot test failed. Please check the workflow run for details.