search

clockworklabs / SpacetimeDB

Multiplayer at the speed of light
https://spacetimedb.com
Other
4.41k stars 110 forks source link

CLI should not depend on rustup #1996

Open mamcx opened 1 week ago

mamcx commented 1 week ago

Description of Changes

Rustup could not be installed (for example, for people who use nix).

Now, the cli defensively check for it. It also try to find the target wasm32-unknown-unknown in case is not installed.

Closes #1971.

API and ABI breaking changes

If this is an API or ABI breaking change, please apply the corresponding GitHub label.

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do, so that you're confident that all the changes work as expected!

bfops commented 2 days ago

Looks basically good to me, two small comments