clockworklabs / SpacetimeDB

Multiplayer at the speed of light
https://spacetimedb.com
Other
4.15k stars 100 forks source link

Fix benchmarks please 100% #481

Closed coolreader18 closed 7 months ago

coolreader18 commented 7 months ago

Description of Changes

API and ABI

If the API is breaking, please state below what will break

Expected complexity level and risk

How complicated do you think these changes are? Grade on a scale from 1 to 5, where 1 is a trivial change, and 5 is a deep-reaching and complex change.

This complexity rating applies not only to the complexity apparent in the diff, but also to its interactions with existing and future code.

If you answered more than a 2, explain what is complex about the PR, and what other components it interacts with in potentially concerning ways.

coolreader18 commented 7 months ago

I'm actually not necessarily 100% on this but I'm kinda confused. the error is "Message: Resource not accessible by personal access token, Locations: [{Line:1 Column:49}]", which looking at the github cli source code seems to indicate that it's a graphql error. but this isn't using graphql? so idk what the deal is

coolreader18 commented 7 months ago

ohhh ok now I think I get it - it's the comment that's failing, maybe?

coolreader18 commented 7 months ago

though that would still mean that the check is failing :/

coolreader18 commented 7 months ago

ok maybe I'll just try something real quick

coolreader18 commented 7 months ago

for faster iteration

coolreader18 commented 7 months ago

Ok, NOW I'm confident this'll work.