search

clockworklabs / com.clockworklabs.spacetimedbsdk

The SpacetimeDB SDK for C# clients
https://spacetimedb.com
Apache License 2.0
6 stars 0 forks source link

Bump version to 0.9.2 #95

Closed bfops closed 3 months ago

bfops commented 3 months ago

Description of Changes

Just bumps the version number. Since 0.9.1 has been released, we are now on 0.9.2+!

API

If the API is breaking, please state below what will break

Requires SpacetimeDB PRs

List any PRs here that are required for this SDK change to work

RReverser commented 3 months ago

Did we land any new changes for that one? If not, I'm pretty sure that back when we talked about it, Tyler said we don't need to keep patch versions the same across SDKs because each SDK might have its own changes / development not related to SpacetimeDB itself.

So we set 0.x to match across SDKs but last patch component is for each SDKs own iteration.

RReverser commented 3 months ago

As discussed in chat, let's either bump one up (to 0.9.1) or just not bump at all since master already has a tag so no new changes here.

kurtismullins commented 3 months ago

As discussed in chat, let's either bump one up (to 0.9.1) or just not bump at all since master already has a tag so no new changes here.

I think that moving forward, this is a good idea. Since @bfops already had the versions set to v0.9.2-beta, I decided to leave it there for this release. I will not merge this Pull Request so that master is unaffected. Just note that the latest version pushed to nuget is v0.9.2.

As mentioned in Discord -- we did skip v0.9.1. Maybe someone can just push a release there so its not missing? It can be the same as v0.9.0. I don't think its super important but does look weird, historically speaking.

RReverser commented 3 months ago

I will not merge this Pull Request so that master is unaffected. Just note that the latest version pushed to nuget is v0.9.2.

Well if it's published to nuget, then let's merge it. Github repo should reflect nuget state, or the next person trying to bump version is gonna be even more confused.

RReverser commented 3 months ago

In fact, we should have merged it before I merged https://github.com/clockworklabs/spacetimedb-csharp-sdk/commit/025a84cded5f38a050262c8afaacfafd8169f233 as the history looks weird now (that commit is not part of 0.9.2, even though it precedes it). Oh well...