clockworkpi / launcher

The launcher for GameShell
GNU General Public License v3.0
333 stars 79 forks source link

fix broken wallpaper paths #230

Closed rqm closed 5 years ago

rqm commented 5 years ago

The paths for the gameover and seeyou wallpapers are broken, as a result the loading wallpaper is displayed instead (i.e. on shutdown).

This patch fixes the issue.

cuu commented 5 years ago

have u tested? it seems fine here, I've tested both in Setting or the Toplevel menu ,PowerOFF, at least everytime I can see the See you Picuture

cause launcher running in the folder ~/launcher/sys.py ,so there is no need for a full path

rqm commented 5 years ago

Yep was tested, I was playing around with alternative skins loaded from /home/cpi/skins/* and got the loading wallpaper instead of the seeyou one at shutdown. Using full path fixed it.

rqm commented 5 years ago

To give you more details, I was using a theme that has its own wallpaper images, so I backed up the default ones and created a symlink from /home/cpi/skins/myskin/wallpaper to ~/launcher/sys.py/gameshell/wallpaper, and somehow the images were not loading, unless using full path. I will run the scenario again and confirm if it's still happening.

rqm commented 5 years ago

Couldn't reproduce, seems like it works all good even with the symlink, all good !