search

clockworkpi / launcher

The launcher for GameShell
GNU General Public License v3.0
332 stars 79 forks source link

Humbling #249

Closed noahbechtel closed 5 years ago

noahbechtel commented 5 years ago

Cut the amount of files edited, removed .ds_store.

cuu commented 5 years ago

Hi man A lot of improvements as we can see

here is my opinion in Menu/GameShell/10_Settings/Wallpaper/__init__.py if the wallpaper's png filename does not include "_", launcher will panic

line 206 function Click you just typed f***k words,which is not inappropriate for a public project ,you may get mad of python But should not include into codes

in Menu/GameShell/10_Settings/list_page.py you changed labels in alist ,Skins => Theme Manger

in sys.py/UI/title_bar.py you deleted the title = MyLangManager.Tr(title) this will cause Titlebar has no translations

I think I'll close this issue ,and I cloned your repo, This feature is good So we will include it into launcher as name of Background,under Skin section

Thanks very much