Closed sagikazarmark closed 7 years ago
You're killin' me :)
I'm very reluctant to go to 4-space indenting in the templates... that be a mess to do with little real gain and would make them inconsistent with the apparent standard with the rest of the chart world.
But if you really like 4 spaces for the Travis file, oh, alright. 😄
And as for the .yaml
thing, oh well... /shrug
Merge away, my friend!
I'm very reluctant to go to 4-space indenting in the templates... that be a mess to do with little real gain and would make them inconsistent with the apparent standard with the rest of the chart world.
Me too, but normally I hate 2 spacing.
Can you turn on travis to see if it works before merging?
Travis enabled! 🙂
On Nov 19, 2017, at 5:31 PM, Márk Sági-Kazár notifications@github.com wrote:
I'm very reluctant to go to 4-space indenting in the templates... that be a mess to do with little real gain and would make them inconsistent with the apparent standard with the rest of the chart world.
Me too, but normally I hate 2 spacing.
Can you turn on travis to see if it works before merging?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or mute the thread.
I usually prefer 4 spaces for indentation, because 2 spaces are really unreadable. But helm charts seem to follow that practice. So I usually leave consistency when it comes to helm charts. :) Indenting with 4 spaces would be a huge work at this point, because of the go template parts which are not supported by IDEs. So I vote for inconsistency here, unless I convinced you.
As for the travis file: https://github.com/travis-ci/travis-ci/issues/672