search

clog-tool / clog-cli

Generate beautiful changelogs from your Git commit history
MIT License
863 stars 43 forks source link

Parsing pull request message #83

Open nvanheuverzwijn opened 8 years ago

nvanheuverzwijn commented 8 years ago

Is there any way clog-cli can parse a github PR commit message ? In our workflow, we do use feature/branch and are using PR only. When we merge the PR, we set the conventional commit message into the long commit message of the PR but clog fails to parse this part of the commit.

kbknapp commented 8 years ago

Only if that message is in the git history itself and the commit subject matches on of the clog triggers then yes. But If it's just the github comment in the PR it won't get picked up by clog.

The easiest way to ad that, is to either rebase the PR or just add a commit with that comment.

nvanheuverzwijn commented 8 years ago

What I'm talking about is this kind of commit made by github PR:

commit a216f0deff6e2de2a91bf9d0e88f8f00544f3d33
Merge: cddc5e8 261d9ca
Author: Nicolas Vanheuverzwijn
Date:   Fri Feb 12 16:23:36 2016 -0500

    Merge pull request #12 from nvanheuverzwijn/feature/test  <<< shot commit message

    feat(Test): new test  <<< long commit message which can be on many lines

The long commit message does not seem to be parsed. But I think this might be intended on clog part? I may be mistaken. I'm using clog v0.9.1

kbknapp commented 8 years ago

Ah ok, I understand, let me play with it a bit and see what I can figure out.