Update Gradle dependency notation - Githubissues

clojars / clojars-web

A community repository for open-source Clojure libraries

https://clojars.org

Eclipse Public License 1.0

469 stars 114 forks source link

Update Gradle dependency notation #803

Closed JohnnyJayJay closed 3 years ago

JohnnyJayJay commented 3 years ago

This PR updates the dependency notation to be \ implementation("group:artifact:version")\ instead of\ compile 'group:artifact:version'.

Why?

This notation is DSL-agnostic - the previous notation only works in the Groovy DSL, this works in both Groovy and Kotlin.
compile should not be used anymore - implementation was introduced in Gradle 3.4 as a better default that does not expose the dependency to sub-dependencies. Subsequently, compile was deprecated and now finally removed in the latest Gradle version, 7.0.

tobias commented 3 years ago

Thanks for updating this! I'll get this out in the next release.