search

clojure-android / lein-droid

A Leiningen plugin for building Clojure/Android projects
Eclipse Public License 1.0
645 stars 56 forks source link

add new option :sigalg #45

Closed ayamada closed 11 years ago

ayamada commented 11 years ago

jarsigner causes error when not matched private key's algorithm (-keystore's key's algorithm) and sign's algorithm (-sigalg) on http://developer.android.com/tools/publishing/app-signing.html#signapp . And, lein-droid use -sigalg to MD5withRSA now. It requires RSA private key. But, I generated DSA private key in past times and used it for past Android apps. So, I want to change -sigalg to SHA1withDSA for support DSA private key.

I add :sigalg new option for it. How does this look?

alexander-yakushev commented 11 years ago

Thank you, ayamada. I merge this for now as a temporary solution, but I should get back to it soon. The initial sign-apk was written so it "just worked" but all options should eventually be supported (like -digestalg). Also, the manual suggests SHA1withRSA as sigalg, so I should test if it works and set is as the default algorithm.

ayamada commented 11 years ago

I see! Thank you, Alexander.