search

clojure-android / lein-droid

A Leiningen plugin for building Clojure/Android projects
Eclipse Public License 1.0
645 stars 56 forks source link

revert set-profiles to unmerge-profiles and merge-profiles #51

Closed ayamada closed 11 years ago

ayamada commented 11 years ago

Hi, Alexander.

You changed from (unmerge-profiles [:dev]) (merge-profiles [:release]) to (set-profiles [:release] [:dev]) at c8b06e0ff14fa85dd4d65865a1e19cc36256f2a5 . But it causes to disable to lein with-profiles ... function at release time. Because, unmerge-profiles and merge-profiles cared with-profiles profiles, but set-profiles not care with-profiles profiles. (See https://github.com/technomancy/leiningen/blob/master/leiningen-core/src/leiningen/core/project.clj#L612 . merge-profiles and unmerge-profiles includes (concat included-profiles profiles), but set-profiles not includes this code.)

I need to with-profiles for to change some environments. Will you be so obliging as to see this problem.

alexander-yakushev commented 11 years ago

Hi Atsuo,

You are correct, thank you for reporting this. There is actually one more bug introduced by that commit, I plan to see if both of them are fixed with your patch. It is possible that I'll rewrite the original buggy commit altogether.

alexander-yakushev commented 11 years ago

Atsuo, you were absolutely correct. Your fix solves both your issue and another issue I was having. Thank you so much, once again you saved the day!

ayamada commented 11 years ago

Thank you! I'm glad to assist your works!