search

clojure-android / lein-droid

A Leiningen plugin for building Clojure/Android projects
Eclipse Public License 1.0
645 stars 56 forks source link

Added explicit build-tools version handling #97

Closed worrel closed 10 years ago

worrel commented 10 years ago

Parsed either build-tools-version or name of build-tools subfolder to determine version. Also includes updated tool location for zipalign for v20. Note, shemefully, I'm unable to build the plugin to test this (lein seems to hang & peg 1 core at max), but the code works at the REPL.

alexander-yakushev commented 10 years ago

Good, thank you. I'm thinking if it is time to give-up the "non-buildtools` case, as I doubt someone still uses SDK that old.

worrel commented 10 years ago

You're right, made it a String for now. Also resolved my weird Leiningen issue (upgrading to 2.4.2 from 2.4.0 fixed it) so I was able to test this out.

worrel commented 10 years ago

Hmm OK, but how do you handle the difference between say, v19 and v20 of the build tool then? I just installed the v20 some tools are in different places: zipalign is now in build-tools for instance, so lein-droid 0.2.3 fails in this case.

alexander-yakushev commented 10 years ago

I mean having these three conditions:

(cond (>=  bt-ver 20) ...
      bt-dir ...
     :else ...)
alexander-yakushev commented 10 years ago

I modified your PR to remove the code responsible for handling BT ver. <17. Thank your for cooperation!

worrel commented 10 years ago

Thanks! Sorry about radio silence - I was on extended vacation.

alexander-yakushev commented 10 years ago

That's cool:) lein-droid 0.3.0 is incoming soon with this change inside.