clojure-android / neko

The Clojure/Android Toolkit
Other
297 stars 36 forks source link

:text-size trait uses the wrong scale #14

Closed ghost closed 10 years ago

ghost commented 10 years ago

The text-size trait uses the setTextSize (float size) method, which according to the API docs takes a size in scaled pixels, that is :sp

However the trait applies to-dimension, which yields px, resulting in overall larger text than intended.

Proposed Fix: Use setTextSize (int unit, float size) directly, skipping the manual conversion.

alexander-yakushev commented 10 years ago

OK, I've pushed a fix following your advise. Thank you!