clojure-android / neko

The Clojure/Android Toolkit
Other
297 stars 36 forks source link

Fix a build error #32

Closed jaccarmac closed 10 years ago

jaccarmac commented 10 years ago

The key should be :target-version instead of :target-sdk. For some reason, :ics was not working. An explicit "17" does. Explicit JVM options make sure the resulting JAR can be DEXed.

alexander-yakushev commented 10 years ago

:target-sdk is certainly wrong, but I wonder why :ics doesn't work. I'll merge the PR when I investigate what's going on.

About the JVM option, do you use Java 8?

jaccarmac commented 10 years ago

I do. Also, I realized yesterday that I made a silly error and confused :ics and "17". :ics should be "15". A fix commit is incoming. The Java options are probably a good idea to future-proof the build process.

alexander-yakushev commented 10 years ago

Thank you. Can you please merge the commits in your branch and force-push them?

jaccarmac commented 10 years ago

Done in 427a9d3.

alexander-yakushev commented 10 years ago

Thank you, merged.