search

clojure-android / neko

The Clojure/Android Toolkit
Other
297 stars 36 forks source link

4.0 - Small improvements #53

Closed Malabarba closed 9 years ago

alexander-yakushev commented 9 years ago

Regarding the listeners commit: I'm pretty sure the type hint for the return value should go before the function name, not the arglist. Although I can't remember how to properly typehint multi-arity functions. Can you please link to some docs that state the correct approch?

Malabarba commented 9 years ago

Regarding the listeners commit: I'm pretty sure the type hint for the return value should go before the function name, not the arglist. Although I can't remember how to properly typehint multi-arity functions. Can you please link to some docs that state the correct approch?

Sure. Here is the link on both accounts http://clojure.org/java_interop#Java%20Interop-Type%20Hints

alexander-yakushev commented 9 years ago

Huh. I knew it works, but I was convinced it was an incidental implementation detail. Good.

Everything is fine, now I gonna ask you to rebase your branch on top of the newest 4.0 as I've pushed some stuff to it today. There's nothing that interferes with your patch, but I want to be able to cleanly merge your commits.

Malabarba commented 9 years ago

Done.

alexander-yakushev commented 9 years ago

Thanks!