search

clojure-doc / clojure-doc.github.io

Clojure Guides | Getting Started With Clojure | Clojure Tutorials
https://clojure-doc.github.io
47 stars 16 forks source link

Data structures cookbook - partial review #54

Closed bobisageek closed 1 year ago

bobisageek commented 1 year ago

This PR isn't meant to be merged, but I'm hoping for maybe a skim and feedback on the content for the cookbook. It's WIP, but I figure rather than dropping a whole page, I'd ask for a review of one section and see if anything stands out as problematic.

No rush, no obligation. :)

seancorfield commented 1 year ago

This is a great start and there were a couple of suggestions in it that I hadn't considered (in over a decade of Clojure!) so, yeah, I will be happy to merge this whenever you want and can find more time to work on it! Thank you, @bobisageek !

seancorfield commented 1 year ago

Looking good! Only a few more sections to add, it seems!

seancorfield commented 1 year ago

How do you feel about a review at this point (or a merge)? I really appreciate the work you've put in on this!

bobisageek commented 1 year ago

Sure. I've removed the sequences header for now so that the page doesn't have an empty section, but obviously it can still be added to.

seancorfield commented 1 year ago

We can add a sequences section later. This is a big help, thank you!

seancorfield commented 1 year ago

The site has been regenerated with your new cookbook in place. Some pages have author credits on them, usually with the original author's name and email address but I think some are GH links -- would you like that added and, if so, how would you like to be recognized?

bobisageek commented 1 year ago

no need to worry about it for now - I'll think it over, and maybe when I add some sequence content I'll throw a little credit at the bottom if that's ok

seancorfield commented 1 year ago

Works for me! Thanks, again for your contributions!