Bump Compliment

[bbatsov]

Please, mention this in the changelog as well.

[vemv]

I had it pending to try this, sorry about that!

I'd like to give it a few days usage, now for real.

https://github.com/clojure-emacs/cider-nrepl/issues/836 is a precondition as well

[bbatsov]

I guess now we can continue with this PR.

[alexander-yakushev]

Managed to somehow accidentally close it after rebasing.

[alexander-yakushev]

Tests seem to be failing semi-randomly, does anyone have any immediate ideas? Or should I investigate case by case?

[vemv]

It's always complete-test, right?

I'd appreciate if you could give it a shot, however don't hesitate pinging for a second pair of eyes

[alexander-yakushev]

I'm an idiot. Didn't know that cider-nrepl specifies completion sources explicitly.

[alexander-yakushev]

1.9 stuff still fails. Does everybody agree that cider-nrepl should get the same treatment as nREPL testing matrix-wise? https://github.com/nrepl/nrepl/pull/305

[vemv]

Normally we'd say "not yet" but recently we discovered that 1.9 was unawarely broken:

https://github.com/clojure-emacs/cider-nrepl/pull/840

So I'd vote for dropping it again 👍

[alexander-yakushev]

I took the liberty of refactoring CI config to remove the excludes, and instead cover the correct matrix cells with more sets. WDYT?

[alexander-yakushev]

Normally we'd say "not yet" but recently we discovered that 1.9 was unawarely broken

Besides, it makes sense that cider-nrepl compatibility is equal or a subset the nREPL one, not a superset.

[alexander-yakushev]

I almost succeeded, but tests for JDK8 and legacy parser still fail. I would need some help with this one.

[vemv]

While the refactoring is certainly welcome, I'd appreciate if the changes merely removed the 1.8 and 1.9 from the excludes matrix.

That way we can be sure that the failures don't have to do with the refactoring itself.

You can propose the refactoring afterwards (or just now, in an isolated PR)

Thanks!

[bbatsov]

I took a quick look at the failing tests, and I'm puzzled by them, as they haven't been changed in a while and don't seem to have any relation to completion. I don't think they haven't anything to do with the parser version either.

[vemv]

Can second that, but master is green and hasn't shown flakiness in that particular area.

[vemv]

I'm working on merging this as we speak

[vemv]

https://github.com/clojure-emacs/cider-nrepl/commit/5afa8c6afd03d5a94f661eb00d849063d72d8efc

Thanks for your work!

[vemv]

https://github.com/clojure-emacs/cider/releases/tag/v1.13.0 https://github.com/clojure-emacs/cider-nrepl/blob/master/CHANGELOG.md#0450-2024-01-14

[alexander-yakushev]

Awesome, thanks!