clojure-emacs / cider-nrepl

A collection of nREPL middleware to enhance Clojure editors with common functionality like definition lookup, code completion, etc.
https://docs.cider.mx/cider-nrepl
677 stars 176 forks source link

Restore 1.9 compat, drop 1.8 compat #840

Closed vemv closed 8 months ago

vemv commented 9 months ago

Closes https://github.com/clojure-emacs/cider-nrepl/issues/836

1.8 compat, while it was intended to be, was broken for a possibly very long time.

The reason being, the CI matrix as introduced in 1016f61754c5bcf58ed745a88620381f4afc749d was broken: CircleCI set VERSION, while the Makefile expected CLOJURE_VERSION.

So, surely, progressively factual support degraded.

This commits fixes 1.9 compatibility and ensures that the CI matrix runs as intended.

I deem 1.8 not worth fixing, given that:

bbatsov commented 8 months ago

nobody complained;

Can't argue with this argument. 😆 Thanks for tackling this!