Closed darkleaf closed 7 months ago
Nice fix, thanks much!
I will merge it. First, please:
export LEIN_JVM_OPTS="-Dmranderson.internal.no-parallelism=true"; PROJECT_VERSION=0.45.0 make install
in the project root
Cheers - V
The changes look good to me. @vemv did you by any chance forgot to revisit this PR?
@darkleaf have you been testing out this changes locally in the meantime?
@darkleaf have you been testing out this changes locally in the meantime?
Yes
Awesome - thank you!
PR LGTM after addressing @bbatsov 's feedback
Thanks much!
There should be a release within the next few days.
Fixes #846
Before submitting a PR make sure the following things have been done:
cider.nrepl
ns which has all middleware documentation.lein docs
afterwards, and commit the results.Note: If you're just starting out to hack on
cider-nrepl
you might find nREPL's documentation and the "Design" section of the README extremely useful.*Thanks!
resolve
have an extra arity for&env
looks-step-innable?
for backwards compatibility