search

clojure-emacs / cider-nrepl

A collection of nREPL middleware to enhance Clojure editors with common functionality like definition lookup, code completion, etc.
https://docs.cider.mx/cider-nrepl
677 stars 176 forks source link

Add integration tests for next/previous-sibling ops #859

Closed p4v4n closed 5 months ago

vemv commented 6 months ago

Thanks - very happy to get extended coverage!

I'll take a good look once the build is green

p4v4n commented 6 months ago

Thanks - very happy to get extended coverage!

I'll take a good look once the build is green

Not sure if it can be fixed though as it is failing only for the legacy parser.

I was afraid the additional metadata might cause some issue in the future but there was no way to add tests for the rendered content without them.

vemv commented 6 months ago

No issue, will be eyeing

p4v4n commented 6 months ago

No issue, will be eyeing

The previous test failure shows a discrepancy between the parsers. It didn't feel like a bug I could fix realistically so switched to a safer test case without much metadata on page.