search

clojure-emacs / cider-nrepl

A collection of nREPL middleware to enhance Clojure editors with common functionality like definition lookup, code completion, etc.
https://docs.cider.mx/cider-nrepl
677 stars 176 forks source link

[inspector] Pass :spacious option to Orchard inspector #871

Closed alexander-yakushev closed 5 months ago

alexander-yakushev commented 5 months ago

I feel stupid, does bencode support passing boolean false? :)

bbatsov commented 5 months ago

It doesn’t support Boolean values.

On Fri, May 3, 2024, at 2:46 PM, Oleksandr Yakushev wrote:

I feel stupid, does bencode support passing boolean false? :)

You can view, comment on, or merge this pull request online at:

https://github.com/clojure-emacs/cider-nrepl/pull/871

Commit Summary

• 133743f https://github.com/clojure-emacs/cider-nrepl/pull/871/commits/133743f3e908c9c429840eaa915d0538e0a47d92 [inspector] Pass :spacious option to Orchard inspector File Changes

(3 files https://github.com/clojure-emacs/cider-nrepl/pull/871/files)

• M project.clj https://github.com/clojure-emacs/cider-nrepl/pull/871/files#diff-274071745a4e2a04b647d79d500537e6dc13eee54f44d0426140026293701d1b (2) • M src/cider/nrepl/middleware/inspect.clj https://github.com/clojure-emacs/cider-nrepl/pull/871/files#diff-2d94dd0e5df3764b260b1bf0208d491c564b44a95f47aa0678d7046c7fd0d754 (5) • M test/clj/cider/nrepl/middleware/inspect_test.clj https://github.com/clojure-emacs/cider-nrepl/pull/871/files#diff-dad4210099d15eaf966a1e2eb8ec6f23aced354c5b2fcb46e167b2b2a2874791 (17) Patch Links:

• https://github.com/clojure-emacs/cider-nrepl/pull/871.patch • https://github.com/clojure-emacs/cider-nrepl/pull/871.diff

— Reply to this email directly, view it on GitHub https://github.com/clojure-emacs/cider-nrepl/pull/871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZLSTGX2UVUSFT6AYQLUDZAOBK7AVCNFSM6AAAAABHFOW6TCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3TONRRGAYTMOI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

vemv commented 5 months ago

I wasn't able to get it working - are you?

This is my CIDER request:

(-->
  id              "24"
  op              "eval"
  session         "1c9d380b-7a19-40c3-b6d8-9c4af1fbfb2d"
  time-stamp      "2024-05-03 17:41:50.089558000"
  code            "*1"
  inspect         "true"
  max-atom-length 150
  max-coll-size   5
  ns              "zzzzzzzzzz"
  page-size       32
  spacious        "false"
)
alexander-yakushev commented 5 months ago

Yes, it works for me with a local install.

image
vemv commented 5 months ago

My bad, I had Orchard 0.24 in my cp for other reasons.