Closed plexus closed 6 years ago
Ah, great catch! @vspinu made this flexible pretty recently and I guess you're the first person to take advantage of the configurable nature of the command. :-)
@vspinu FYI - I plan to cut the new CIDER release in a week or two. Keep this in mind, if you'd like to work on more sesman improvements. Seems the current snapshot is behaving reasonably well for most people, so I guess we can finally promote it to an official release soon.
Ok. I will fix this and other connection issues by then.
I haven't had time for the REPL<>connection refactoring as the other sesman issues and session browser cut too big of a dent in my time. Unfortunately it will have to wait.
Expected behavior
This is expected to connect a CLJ and CLJS repl, the CLJS repl using `'my-repl-type'
Actual behavior
This pops up a prompt asking "Select ClojureScript REPL type: ".
The reason this happens is:
cider-connect-clj&cljs
callscider-connect-sibling-cljs
callscider--gather-connect-params
. This last one ends up overriding the specified value for:cljs-repl-type
withcider-cljs-repl-type
, which by default isnil
.Steps to reproduce the problem
Run the above snippet, you can change
'my-repl-type
to e.g.'figwheel
. As long as you haven't explicitly setcider-cljs-repl-type
, you'll get this prompt.Environment & Version information
CIDER version information
Include here the version string displayed when CIDER's REPL is launched. Here's an example:
Lein/Boot version
E.g. Lein 2.6.1 (skip this when you didn't start the nREPL server using Lein or Boot)
Emacs version
E.g. 24.5 (use M-x emacs-version to check it if unsure)
Operating system
E.g. Fedora 23, OS X 10.11 "El Capitan", Windows 10, etc