Open vemv opened 6 months ago
I reworked this PR to not introduce any defcustoms - ready now!
Thanks for the update, I'll review it tomorrow.
I checked the cider-inspector.el
code and it seems the dependency on cider-eval.el
is there just to access a single variable from there. Perhaps a better fix would be a simple declare
or removing that prefix. After all we're not really doing an eval here anyways.
My overall intent is the possibility to have the
*cider-inspect*
buffer permanently on a background frame. cider-eval would have that frame's cider-inspect buffer re-rendered, without switching to it, given that I personally find that only a fraction of evals deserve inspection.This wasn't possible before, as CIDER would detect that my frame wasn't visible, so it would render the buffer in a random window of the visible frame.
Commits:
cider-popup-buffer-display
: Do nothing if the intended buffer is visible in another frame andselect
is nilcider-eval
: support re-rendering the Inspector buffer whencider-inspector-auto-select-buffer
is set to nil and there's a*cider-inspect*
buffer shown in a non-visible frameResult truncated
message more accurate*cider-inspect*
buffer visible, we shouldn't suggest the user to inspect the value again.Cheers - V