search

clojure-emacs / cider

The Clojure Interactive Development Environment that Rocks for Emacs
https://cider.mx
GNU General Public License v3.0
3.54k stars 646 forks source link

add macos aarch64 java/17 integration testing #3671

Closed ikappaki closed 4 months ago

ikappaki commented 4 months ago

Hi,

could you please review follow patch up to #3669, to add integration testing for java/17 on the apple silicon on @vemv's request.

I've also added the badge for the ci integration tests on the github workflows, which was long overdue.

Thanks

bbatsov commented 4 months ago

Seems to me we might be overdoing the platforms (OS + JVM) on which we run the integration tests, as I don't recall much problems historically that they have caught, but I'll merge this regardless. Adding the badge is a good idea. Thanks!

vemv commented 4 months ago

Thanks, @ikappaki !

Seems to me we might be overdoing the platforms (OS + JVM) on which we run the integration tests, as I don't recall much problems historically that they have caught,

It's a relatively young solution (< 1 year), a good chunk of its value being that we don't unawarely break the underlying feature that introduced those tests.