search

clojure-emacs / cider

The Clojure Interactive Development Environment that Rocks for Emacs
https://cider.mx
GNU General Public License v3.0
3.52k stars 643 forks source link

Add an alternative way to display `cider-cheatsheet-select` #3686

Closed katomuso closed 1 month ago

katomuso commented 1 month ago

Instead of having the multi-step selection process, which is the default cider-cheatsheet-select behavior, we represent each candidate as a full path to a var when cider-cheatsheet-select is called with a prefix argument. This can be handy with fuzzy completion style and vertical candidates display, as discussed in #3678.

Here's how the default multi-step selection process looks when you need to select every single section before choosing a var: cider-cheatsheet-select-default

In contrast, when cider-cheatsheet-select is called with a prefix argument, each candidate is a full path to a var: cider-cheatsheet-select-flat

bbatsov commented 1 month ago

Nice improvement - i definitely like it.

katomuso commented 1 month ago

I wonder why the lint check failed because eldev lint shows no warnings...

katomuso commented 1 month ago

I wonder why the lint check failed because eldev lint shows no warnings...

Oh, I found it. It has to do with byte compilation and the string-split function. I don't need to fix this kind of warnings, right?

bbatsov commented 1 month ago

You just need to require subr-x and the error will go away.

katomuso commented 1 month ago

You just need to require subr-x and the error will go away.

Hmm, it seems that the error is still present, as string-split is located in subr.el, while other string functions indeed are located in subr-x.el.

bbatsov commented 1 month ago

Ah, my bad. Then it's very weird, as subr.el is auto-required always.

bbatsov commented 1 month ago

Hmm, I see that the function is actually named split-string, so it seems the warning has discovered an actual error. :-)

katomuso commented 1 month ago

So now that all the checks are passing, can I add a new entry to the changelog so we can merge the change? I'll add customizable variables in the future as I am still not sure about some of the details.

bbatsov commented 1 month ago

Sure.

On Wed, May 29, 2024, at 12:47 PM, Kato Muso wrote:

So now that all the checks are passing, can I add a new entry to the changelog so we can merge the change? I'll add customizable variables in the future as I am still not sure about some of the details.

— Reply to this email directly, view it on GitHub https://github.com/clojure-emacs/cider/pull/3686#issuecomment-2137114693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAZLSSHRK6MY4MLFXJ4MVDZEWW5FAVCNFSM6AAAAABIOL3A7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZXGEYTINRZGM. You are receiving this because you commented.Message ID: @.***>

bbatsov commented 1 month ago

Thanks!