cider-jack-in does not enable cider mode on clojure buffers

clojure-emacs / cider

The Clojure Interactive Development Environment that Rocks for Emacs

https://cider.mx

GNU General Public License v3.0

3.55k stars 646 forks source link

cider-jack-in does not enable cider mode on clojure buffers #394

Closed zilvinasu closed 11 years ago

zilvinasu commented 11 years ago

After the recent update I got from MELPA, Cider mode not being enabled on current and new Clojure buffers.

bbatsov commented 11 years ago

I'll have a look at that. Yesterday I was doing some refactoring of this functionality and I guess I've accidentally broken something.

bbatsov commented 11 years ago

I cannot reproduce this - cider-mode was enabled properly after cider-jack-in when I tried out the latest MELPA package.

zilvinasu commented 11 years ago

Might be something wrong with my config, I will check it later this day

zilvinasu commented 11 years ago

@bbatsov iirc there shouldn't be any additional config necessary for this to work? If so would you mind sharing your cider configs?

zilvinasu commented 11 years ago

My bad, after investigating my config, I found out that I am still using

nrepl-enable-on-existing-clojure-buffers

which did not work, so I switched it to

cider-enable-on-existing-clojure-buffers

works fine now.

avescodes commented 11 years ago

Hey @bbatsov, I think I may be running into this myself.

I'm on cider-20131023.1732 from MELPA, GNU Emacs 24.3.1, with no customizations in my config, and my old nrepl elpa directory deleted.

If I create a test.clj file that looks like:

(+ 1 2)

Open that file with emacs:

emacs test.clj

Then issue the command M-x cider-jack-in I observe

My test.clj buffer's modeline remain unchanged as (Clojure Paredit Projectile Fill)
A blank *cider* buffer open with the modeline (REPL ElDoc Projectile)

My *messages* buffer populated with these messages:

Starting nREPL server...
nREPL server started on 63281
Connecting to nREPL on localhost:63281...
Connected.  Ryan, this could be the start of a beautiful program.

bbatsov commented 11 years ago

@rkneufeld I guess you don't have anything in the REPL buffer and pressing RET there generates some error? This means that something went wrong during the REPL init - are you sure you don't have some incorrect config lying around?

avescodes commented 11 years ago

@bbatsov: That is true, nothing in the REPL buffer and return generates an error. I will attempt again with no emacs config whatsoever. test.clj is not a part of any leiningen project.

avescodes commented 11 years ago

@bbatsov: I removed my entire elpa/ folder and re-installed all of my packages and the problem went away.