search

clojure-emacs / cider

The Clojure Interactive Development Environment that Rocks for Emacs
https://cider.mx
GNU General Public License v3.0
3.56k stars 645 forks source link

cider-repl font-lock issue #824

Closed luxbock closed 10 years ago

luxbock commented 10 years ago

After a recent upgrade I noticed that font-locking for the prompt fails by coloring the text inserted as well, unless the text starts with a parentheses like character. In the case of anonymous functions and sets, the hash-tag character is also colored. If I cycle input from the history of typed commands, then those commands are always colored with the prompt font as well.

bbatsov commented 10 years ago

Yeah, I noticed this myself. I'll have a closer look at the problem soon.

turtle-bazon commented 10 years ago

Problem still persists. Updated cider yesterday.

turtle-bazon commented 10 years ago

Also I can say that font locking in repl completely broken. Only parentheses colored as needed.

bbatsov commented 10 years ago

I'm aware of that, but don't have any time to deal with this right now. Help welcome! :-)

bbatsov commented 10 years ago

A bit more info regarding this issue:

The problem is here. Replacing font-lock-face with face fixes it, but breaks related modes like rainbow-delimiters. See https://github.com/clojure-emacs/cider/issues/749 for more details.

vspinu commented 10 years ago

The whole font-lock mechanism should be changed to use standard jit-lock fontification. I have plans for that after cider-repl is re-planted on comint-mode. There is little point to play with font-lock before comint is sorted out. Unfortunately I am not likely to have time for that till the end of November. There are also other, more critical, issues waiting to be sorted out in meanwhile.

bbatsov commented 10 years ago

Fixed by https://github.com/clojure-emacs/cider/commit/48fceed956ac6152affdf1d3e3a6da0bac1754da