clojure-emacs / clj-refactor.el

A CIDER extension that provides powerful commands for refactoring Clojure code.
GNU General Public License v3.0
771 stars 111 forks source link

Fix breakage introduced by commit 24ea02bad in clojure-mode #469

Closed iarenaza closed 4 years ago

iarenaza commented 4 years ago

Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

Thanks!

Expected behavior

TravisCI builds run successfully.

Actual behavior

TravisCI builds fail with:

In toplevel form:

clj-refactor.el:962:26:Error: ‘clojure-namespace-name-regex’ is an obsolete variable (as of 5.12.0); use ‘clojure-namespace-regexp’ instead.

The command "./run-travis-ci.sh" exited with 1.

Steps to reproduce the problem

Push new commits to master or rebuild any job for commits done after March 20, 2020 (the day commit 24ea02bad was added to clojure-mode)

Environment & Version information

clj-refactor.el version information

Latest master commit

CIDER version information

The version specified in TravisCI build configuration.

Leiningen or Boot version

The version specified in TravisCI build configuration.

Emacs version

The version specified in TravisCI build configuration.

Operating system

The version specified in TravisCI build configuration.

bbatsov commented 4 years ago

Yeah, I've noticed this in the CI, but I forgot to update it. The regular expressions are different, though, so I'm not sure we can just replace one with the other.

//cc @yuhan0

yuhan0 commented 4 years ago

The function doesn't appear to be using the match-data which previously tried to match the ns name, so it should be equivalent.

bbatsov commented 4 years ago

Okay then. Thanks for you input! And thanks to @iarenaza for tackling this!