clojure-emacs / clj-refactor.el

A CIDER extension that provides powerful commands for refactoring Clojure code.
GNU General Public License v3.0
773 stars 111 forks source link

Send nREPL-based paths instead of CIDER-based paths #474

Closed iarenaza closed 4 years ago

iarenaza commented 4 years ago

When cider-path-translations is in use (e.g., when CIDER is running on the host, but the nREPL is running in a VM or a Docker container) we need to translate the local CIDER-based paths to the remote nREPL-based paths for those operations that send paths to nREPL.

We use the new cider-to-nrepl-filename-function that is introduced in CIDER pull request #2897, that should be applied before this one.

Also includes a fix for #442.

Before submitting a PR make sure the following things have been done (and denote this by checking the relevant checkboxes):

Thanks!

expez commented 4 years ago

Excellent! Thank you, @iarenaza!