search

clojure-emacs / clj-refactor.el

A CIDER extension that provides powerful commands for refactoring Clojure code.
GNU General Public License v3.0
773 stars 111 forks source link

Adjust to breaking changes in CIDER #478

Closed plexus closed 3 years ago

plexus commented 3 years ago

Happy new year.

It saddens me deeply that we as a community have not yet moved past this unnecessary churn.

For reference, I generated these based on the now deleted aliases in CIDER (relies on zsh-style globs and GNU sed)

sed 's/cider-connect-clojurescript/cider-connect-cljs/g' -i **/*(.)
sed 's/cider-connect-clojure/cider-connect-clj/g' -i **/*(.)
sed 's/cider-connect-sibling-clojurescript/cider-connect-sibling-cljs/g' -i **/*(.)
sed 's/cider-connect-sibling-clojure/cider-connect-sibling-clj/g' -i **/*(.)
sed 's/cider-current-repl-buffer/cider-current-repl/g' -i **/*(.)
sed 's/cider-current-session/cider-nrepl-eval-session/g' -i **/*(.)
sed 's/cider-current-tooling-session/cider-nrepl-tooling-session/g' -i **/*(.)
sed 's/cider-default-repl-command/cider-jack-in-default/g' -i **/*(.)
sed 's/cider-display-connection-info/cider-describe-connection/g' -i **/*(.)
sed 's/cider-jack-in-clojurescript/cider-jack-in-cljs/g' -i **/*(.)
sed 's/cider-jack-in-clojure/cider-jack-in-clj/g' -i **/*(.)
sed 's/cider-refresh-after-fn/cider-ns-refresh-after-fn/g' -i **/*(.)
sed 's/cider-refresh-before-fn/cider-ns-refresh-before-fn/g' -i **/*(.)
sed 's/cider-refresh-show-log-buffer/cider-ns-refresh-show-log-buffer/g' -i **/*(.)
sed 's/cider-refresh/cider-ns-refresh/g' -i **/*(.)
sed 's/cider-repl-buffers/cider-repls/g' -i **/*(.)
sed 's/cider-repl-set-type/cider-set-repl-type/g' -i **/*(.)
sed 's/cider-save-files-on-cider-ns-refresh/cider-ns-save-files-on-refresh/g' -i **/*(.)
sed 's/cider-switch-to-repl-after-insert-p/cider-switch-to-repl-on-insert/g' -i **/*(.)
sed 's/nrepl-connection-buffer-name/nrepl-repl-buffer-name/g' -i **/*(.)
bbatsov commented 3 years ago

I can also restore the more useful aliases to avoid breakage in the mean time. I don't follow clj-refactor closely and I had falsely assumed it wasn't using anything deprecated. Guess now I know that no one pays attention of deprecation warnings. :-)

bbatsov commented 3 years ago

I've added back the aliases that seem like something that a client could actually be using.