search

clojure-emacs / clj-refactor.el

A CIDER extension that provides powerful commands for refactoring Clojure code.
GNU General Public License v3.0
771 stars 111 forks source link

clj-refactor customize support is missing a defgroup form #482

Closed pierre-rouleau closed 3 years ago

pierre-rouleau commented 3 years ago

Expected behavior

When using M-x customize-group cljr, you should be able to see the group's parent.

Actual behavior

The cljr customize buffer shows: "Group definition missing." instead.

Steps to reproduce the problem

Environment & Version information

Not relevant here, but tested on Emacs 26.3 on macOS Mojave.

clj-refactor.el version information

clj-refactor 2.5.1 (package: 20210216.928)

CIDER version information

N/A.

Leiningen or Boot version

N/A.

Emacs version

Emacs 26.3

Operating system

macOS Mojave

Extra Notes

I can submit a pull-request with the fix.

pierre-rouleau commented 3 years ago

I would solve this with the following change: https://github.com/pierre-rouleau/clj-refactor.el/commit/f735d0949eeae0176bee7ec2413dad7dfe1b7c84

bbatsov commented 3 years ago

Looks good. Guess we overlooked this.

pierre-rouleau commented 3 years ago

I'll submit later today after I have time to setup an environment with Emacs 27 and cask to be able to run your tests

bbatsov commented 3 years ago

For such a simple change that's not really needed. I'm sure it won't break anything.

pierre-rouleau commented 3 years ago

I thought so too, but since I never submitted anything here, I was going to play nice. So OK, I'll go ahead and submit. There's so little time and soooo many things to do...
BTW. Thanks for all of these Clojure projects!

bbatsov commented 3 years ago

I thought so too, but since I never submitted anything here, I was going to play nice. So OK, I'll go ahead and submit. There's so little time and soooo many things to do...

I know what you mean. 😄

BTW. Thanks for all of these Clojure projects!

You're welcome! Btw, you finally pushed me to update the CI build of the project, so at least people can get some feedback on their PRs without having to setup the test developments locally.