search

clojure-emacs / clj-refactor.el

A CIDER extension that provides powerful commands for refactoring Clojure code.
GNU General Public License v3.0
771 stars 111 forks source link

Make the refactor-nrepl version customizable #495

Closed vemv closed 2 years ago

vemv commented 2 years ago

Allows users to try out newer refactor-nrepl releases, which shouldn't be necessarily coupled to clj-refactor.el.

vemv commented 2 years ago

All feedback addressed. Cider's most similar variable is https://github.com/clojure-emacs/cider/blob/adfc1c940d452ace7d1dbea543024d422f60364c/cider.el#L409 .

required would be confusing for something customizable so injected seems clearer.

bbatsov commented 2 years ago

required would be confusing for something customizable so injected seems clearer.

Yeah, the name there is a bit confusing as it's also both the required version (you'll get a warning if your cider-nrepl version is older) and the injected version. Probably I should have used 2 separate defcustoms.

vemv commented 2 years ago

Cheers for the prompt review 🍻

bbatsov commented 2 years ago

You're welcome!